[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixes note column skylines by adding stem tremolo to axis group. (is
Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)
Fri, 12 Aug 2011 00:31:11 +0200
On Aug 11, 2011, at 7:03 PM, Neil Puttock wrote:
> On 11 August 2011 12:34, address@hidden <address@hidden> wrote:
>> I figured out why it works - I figured I'd post this to the list in case
>> anyone else ever wants to mess around with pure properties.
>> The StemTremolo is added to the paper column's element grob array via the
>> axis-group-engraver because it does not have an axis-group-parent-Y.
> I think you mean the VerticalAxisGroup's elements array.
> The StemTremolo is added to a PaperColumn's elements array (and gets
> the column as axis-group-parent-X) in the Paper_column_engraver.
Yes, you're absolutely right.
>> Then, when horizontal spacing happens, its pure height function is passed
>> through for its print function (separation-item.cc).
> I think I understand: before you added the print-to-height conversion,
> the original height callback (ly:stem-tremolo::height) wasn't
> pure-relevant; this resulted in Item::pure_height () returning an
> empty extent, causing the StemTremolo to be left out of the skyline.
> This didn't matter unless the spacing was really tight.