lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ends of barlines are hidden in staff lines. (issue 4809057)


From: n . puttock
Subject: Re: Ends of barlines are hidden in staff lines. (issue 4809057)
Date: Sat, 13 Aug 2011 15:55:07 +0000


http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc
File lily/bar-line.cc (right):

http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc#newcode40
lily/bar-line.cc:40: /* Due to rounding problems, barlines extending to
the outermost edges
bar lines

http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc#newcode43
lily/bar-line.cc:43: The solution is to extend barlines only to the
middle
bar lines

http://codereview.appspot.com/4809057/diff/1/lily/bar-line.cc#newcode48
lily/bar-line.cc:48: SCM staff_color = Staff_symbol_referencer::color
(me);
I think it's overkill to define a new method just to access 'color from
a stave (unless you plan on using it elsewhere)

SCM staff_color = staff->get_property ("color");

http://codereview.appspot.com/4809057/diff/1/lily/staff-symbol-referencer.cc
File lily/staff-symbol-referencer.cc (right):

http://codereview.appspot.com/4809057/diff/1/lily/staff-symbol-referencer.cc#newcode72
lily/staff-symbol-referencer.cc:72: return ly_symbol2scm ("black");
'color is a list: (list R G B)

http://codereview.appspot.com/4809057/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]