[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes heights and pure heights of stems. (issue 4898044)

From: mtsolo
Subject: Re: Fixes heights and pure heights of stems. (issue 4898044)
Date: Tue, 16 Aug 2011 07:38:24 +0000

I see what you mean about flags, and I think there are two ways to go
with it.

1)  Reinstate stem-begin-position and stem-end-position in this patch
(trivial: would take 10 minutes).

2)  Create a Flag grob (less trivial, I'd say two hours of work to
create the grob in define-grobs.scm, get it made in a new finalize
method for the stem engraver, copy and paste all of the flag stuff in into a new, create an X-offset and Y-offset callback for
flags, and rewrite any .ly material that makes references to flags - the
docs is another story).

I like #2 for the same reason that I'd be against conflating stem
tremolos into stems.  Flags, like stem tremolos, are unique entities
that are appended to stems in certain conditions.

File lily/ (right):
lily/ + stem->extent (stem, Y_AXIS)[get_grob_direction
On 2011/08/15 21:57:43, hanwenn wrote:
this looks like a dimension error. what if staffspace != 1.0?

You're right - the multiplier needs to go around both elements.  Fixed
in a new patchset.
File lily/ (right):
lily/ stem_posns[d] = stem->pure_height (stem, 0,
On 2011/08/15 21:57:43, hanwenn wrote:
again, height is in ss, while posns are relative to 0.5*ss

Thanks for spotting this - fixed.
File lily/ (right):
lily/ me->set_property ("Y-extent", ly_interval2scm
On 2011/08/15 21:57:43, hanwenn wrote:
why don't you a callback directly on Y-extent?

I think that a call to set_property needs to be done here irrespective
of the implementation (the same was true of the old function, it was
just a different property (stem-end-position)).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]