[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Has piano pedal brackets end on the right of a note column. (issue 48990
From: |
mtsolo |
Subject: |
Has piano pedal brackets end on the right of a note column. (issue 4899050) |
Date: |
Thu, 18 Aug 2011 10:16:12 +0000 |
Reviewers: ,
Description:
Has piano pedal brackets end on the right of a note column.
Please review this at http://codereview.appspot.com/4899050/
Affected files:
A input/regression/piano-pedal-bracket-end.ly
M lily/piano-pedal-bracket.cc
Index: input/regression/piano-pedal-bracket-end.ly
diff --git a/input/regression/piano-pedal-bracket-end.ly
b/input/regression/piano-pedal-bracket-end.ly
new file mode 100644
index
0000000000000000000000000000000000000000..340c6a510629df351d5b2151aa869e67cdca1b14
--- /dev/null
+++ b/input/regression/piano-pedal-bracket-end.ly
@@ -0,0 +1,19 @@
+
+\version "2.15.9"
+
+\header {
+ texidoc = "Piano pedal brackets should encompass the full note column
+at their end.
+"
+}
+
+\layout {
+ ragged-right = ##f
+}
+{
+ \set Staff.pedalSustainStyle = #'bracket
+ \time 3/4 \key f \major \clef bass
+ <c' bes e>\sustainOn
+ <c' bes e>\sustainOff \sustainOn
+ <c' bes e>\sustainOff
+}
Index: lily/piano-pedal-bracket.cc
diff --git a/lily/piano-pedal-bracket.cc b/lily/piano-pedal-bracket.cc
index
fee4c4b762637bf0b417de7880df1be1e96485f8..3a8186242a6d6151bda585de894800cdd9888cca
100644
--- a/lily/piano-pedal-bracket.cc
+++ b/lily/piano-pedal-bracket.cc
@@ -68,7 +68,7 @@ Piano_pedal_bracket::print (SCM smob)
}
Interval ext = robust_relative_extent (b, common, X_AXIS);
- span_points[d] = ext [broken[d] ? RIGHT : LEFT];
+ span_points[d] = ext [broken[d] || (d == RIGHT && flare[d] == 0.0) ?
RIGHT : LEFT];
}
while (flip (&d) != LEFT);
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Has piano pedal brackets end on the right of a note column. (issue 4899050),
mtsolo <=