Re: Fixes boolean/SCM confusions, part 1. (issue 4875054)

[reinhold . kainhofer]

http://codereview.appspot.com/4875054/diff/1/lily/ambitus-engraver.cc
File lily/ambitus-engraver.cc (right):

http://codereview.appspot.com/4875054/diff/1/lily/ambitus-engraver.cc#newcode177
lily/ambitus-engraver.cc:177: Rational sig_alter = !scm_is_false
(handle)
On 2011/08/18 14:03:06, Cécile Hauchemaille wrote:
> So, might scm_is_pair also work ?

Yes, of course, that's the correct check...

http://codereview.appspot.com/4875054/diff/1/lily/auto-beam-engraver.cc
File lily/auto-beam-engraver.cc (right):

http://codereview.appspot.com/4875054/diff/1/lily/auto-beam-engraver.cc#newcode172
lily/auto-beam-engraver.cc:172: return !scm_is_false (scm_call_4
(get_property ("autoBeamCheck"),
On 2011/08/18 13:31:26, Bertrand Bordage wrote:
> Indent like this:

> return !scm_is_false (scm_call_4 (
>                          get_property ("autoBeamCheck"),
>                          context ()->self_scm (),
> [...]

Or more correct: align the context ()->self_scm () with the
get_property:

return !scm_is_false (scm_call_4 (get_property ("autoBeamCheck"),
                                  context ()->self_scm (),
                                  ...

http://codereview.appspot.com/4875054/