Re: Prevents nested tuplets from colliding. (issue 4808082)

[n . puttock]

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-broken.ly
File input/regression/tuplet-nest-broken.ly (right):

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-broken.ly#newcode5
input/regression/tuplet-nest-broken.ly:5: texidoc = "Broken nested
tuplets avoid each other correctly.
indent

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-broken.ly#newcode50
input/regression/tuplet-nest-broken.ly:50: \Voice \remove
Forbid_line_break_engraver
\Voice
\remove "Forbid_line_break_engraver"

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-force-shift-over-numbers.ly
File input/regression/tuplet-nest-force-shift-over-numbers.ly (right):

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-force-shift-over-numbers.ly#newcode17
input/regression/tuplet-nest-force-shift-over-numbers.ly:17: \times 2/3
{ a8 [a8 a8 ]}
a8[ a a] }

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-force-shift-over-numbers.ly#newcode29
input/regression/tuplet-nest-force-shift-over-numbers.ly:29: a a a a a
a4 a a a a

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-force-shift-over-numbers.ly#newcode31
input/regression/tuplet-nest-force-shift-over-numbers.ly:31: a
a4

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-force-shift-over-numbers.ly#newcode40
input/regression/tuplet-nest-force-shift-over-numbers.ly:40: a a a a a
a4 a a a a

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-force-shift-over-numbers.ly#newcode42
input/regression/tuplet-nest-force-shift-over-numbers.ly:42: a
a4

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest.ly
File input/regression/tuplet-nest.ly (right):

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest.ly#newcode15
input/regression/tuplet-nest.ly:15: \times 2/3 { c8[ c8 c8] }
c8[ c c]

http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest.ly#newcode21
input/regression/tuplet-nest.ly:21: \times 2/3 { a8[ a8 a8] }
a8[ a a]

http://codereview.appspot.com/4808082/diff/13002/lily/tuplet-bracket.cc
File lily/tuplet-bracket.cc (right):

http://codereview.appspot.com/4808082/diff/13002/lily/tuplet-bracket.cc#newcode283
lily/tuplet-bracket.cc:283: SCM scm_x_span = me->get_property
("X-positions");
I seem to recall we discussed the option of splitting control-points
into separate X/Y properties (can't remember exactly which grob it was
for :).  My main concern was the naming since 'positions should be
changed to Y-positions, but this would be disruptive for other grobs.

http://codereview.appspot.com/4808082/diff/13002/lily/tuplet-bracket.cc#newcode669
lily/tuplet-bracket.cc:669: // have to re_run numbers to check for
number-on-number collisions
This is getting a bit complicated.  Do you think it's feasible to have a
grob which would collect the colliding brackets and do the collision
avoidance as a separate positioning-done callback?

http://codereview.appspot.com/4808082/