
From:  n . puttock 
Subject:  Re: Prevents nested tuplets from colliding. (issue 4808082) 
Date:  Fri, 19 Aug 2011 21:58:56 +0000 
http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnestbroken.ly File input/regression/tupletnestbroken.ly (right): http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnestbroken.ly#newcode5 input/regression/tupletnestbroken.ly:5: texidoc = "Broken nested tuplets avoid each other correctly. indent http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnestbroken.ly#newcode50 input/regression/tupletnestbroken.ly:50: \Voice \remove Forbid_line_break_engraver \Voice \remove "Forbid_line_break_engraver" http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnestforceshiftovernumbers.ly File input/regression/tupletnestforceshiftovernumbers.ly (right): http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnestforceshiftovernumbers.ly#newcode17 input/regression/tupletnestforceshiftovernumbers.ly:17: \times 2/3 { a8 [a8 a8 ]} a8[ a a] } http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnestforceshiftovernumbers.ly#newcode29 input/regression/tupletnestforceshiftovernumbers.ly:29: a a a a a a4 a a a a http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnestforceshiftovernumbers.ly#newcode31 input/regression/tupletnestforceshiftovernumbers.ly:31: a a4 http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnestforceshiftovernumbers.ly#newcode40 input/regression/tupletnestforceshiftovernumbers.ly:40: a a a a a a4 a a a a http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnestforceshiftovernumbers.ly#newcode42 input/regression/tupletnestforceshiftovernumbers.ly:42: a a4 http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnest.ly File input/regression/tupletnest.ly (right): http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnest.ly#newcode15 input/regression/tupletnest.ly:15: \times 2/3 { c8[ c8 c8] } c8[ c c] http://codereview.appspot.com/4808082/diff/13002/input/regression/tupletnest.ly#newcode21 input/regression/tupletnest.ly:21: \times 2/3 { a8[ a8 a8] } a8[ a a] http://codereview.appspot.com/4808082/diff/13002/lily/tupletbracket.cc File lily/tupletbracket.cc (right): http://codereview.appspot.com/4808082/diff/13002/lily/tupletbracket.cc#newcode283 lily/tupletbracket.cc:283: SCM scm_x_span = me>get_property ("Xpositions"); I seem to recall we discussed the option of splitting controlpoints into separate X/Y properties (can't remember exactly which grob it was for :). My main concern was the naming since 'positions should be changed to Ypositions, but this would be disruptive for other grobs. http://codereview.appspot.com/4808082/diff/13002/lily/tupletbracket.cc#newcode669 lily/tupletbracket.cc:669: // have to re_run numbers to check for numberonnumber collisions This is getting a bit complicated. Do you think it's feasible to have a grob which would collect the colliding brackets and do the collision avoidance as a separate positioningdone callback? http://codereview.appspot.com/4808082/
[Prev in Thread]  Current Thread  [Next in Thread] 