[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Creates a Flag grob. (issue 4922042)

From: Mike Solomon
Subject: Re: Creates a Flag grob. (issue 4922042)
Date: Mon, 22 Aug 2011 12:20:44 +0200

On Aug 22, 2011, at 12:06 PM, address@hidden wrote:
File input/regression/ (right):
input/regression/ \override Flag #'color = #blue
Why don't you choose a different color to check that the two grobs are
really handled differently?

File lily/ (right):
lily/ '() or "grace").  */
That comment should be moved down to stroke-style

lily/ if (scm_is_string (stroke_style_scm))
Sooner or later, that should be moved out from here into its own grob.
Then we can also have slashed beamed grace notes (which don't have any

File lily/ (right):
lily/ boxes.push_back (Box (flag->extent
(x_refpoint_, X_AXIS), flag->extent (commony, Y_AXIS)));
Line too long

ly/ \override Flag #'flag-style = #'no-flag
Do we need/want a convert-ly warning for \override Stem #'flag-style?

Yes - I'd put this in a separate patch/issue (unless people think it belongs here - it seems that convert-ly rules usually come after patches get pushed).
File scm/define-grob-properties.scm (right):
scm/define-grob-properties.scm:276: (flag-style ,symbol? "A symbol
determining what style of flag
rename to style? Unfortunately, then we don't have any documentation any
more about the valid values... :(

You've hit the proverbial nail on its proverbial head.  It is for this reason that I'm wary about renaming.

New patchset up, and thanks for your comments!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]