lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: modifying default behaviour of tremolo slashes (issue 4636081)


From: lemniskata . bernoullego
Subject: Re: modifying default behaviour of tremolo slashes (issue 4636081)
Date: Mon, 22 Aug 2011 10:11:55 +0000

Regtest added.


http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):

http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc#newcode118
lily/stem-tremolo.cc:118: shape = ly_symbol2scm ("beam-like");
On 2011/08/11 20:05:10, Neil Puttock wrote:
this is redundant unless you want to add a warning for invalid shape
setting
(you only check for rectangle below; anything else falls through to
Lookup::beam
())

True, but shouldn't we leave it to make the code more logical and
elegant (and in case we want to expand it in the future)?

http://codereview.appspot.com/4636081/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]