[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: What's the deal with String_convert::reverse?
|
From: |
Reinhold Kainhofer |
|
Subject: |
Re: What's the deal with String_convert::reverse? |
|
Date: |
Tue, 23 Aug 2011 23:19:47 +0200 |
|
User-agent: |
KMail/1.13.6 (Linux/2.6.38-10-generic; KDE/4.7.0; i686; ; ) |
Am Tuesday, 23. August 2011, 22:30:24 schrieb David Kastrup:
> This function in the flower library relies on memrev which is broken
> (off-by-one error).
hehe, nice catch. It should use
unsigned char *right = byte + length - 1;
shoudln't it?
> Is this used anywhere?
A git grep didn't show any usage, but maybe I'm missing something.
Cheers,
Reinhold
--
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
* Financial & Actuarial Math., Vienna Univ. of Technology, Austria
* http://www.fam.tuwien.ac.at/, DVR: 0005886
* LilyPond, Music typesetting, http://www.lilypond.org