[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix uninitialized variables when Source_file::get_counts returns ear
|
From: |
Han-Wen Nienhuys |
|
Subject: |
Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047) |
|
Date: |
Wed, 24 Aug 2011 10:31:23 -0300 |
On Tue, Aug 23, 2011 at 3:21 PM, <address@hidden> wrote:
> LGTM
>
> Maybe we should have some GOP rules for C++ about this?
Can we not? Professionally, I work with an enormous style guide, and
having a lot of style prescribed needlessly complicates code reviews,
because it makes people hammer on unimportant syntactical details.
We could adopt the following GOP rule about writing functions:
Use your brain when you write and arrange a function.
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), (continued)
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), Carl . D . Sorensen, 2011/08/23
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), ianhulin44, 2011/08/23
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), Graham Percival, 2011/08/23
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), Carl Sorensen, 2011/08/23
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), Ian Hulin, 2011/08/24
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), David Kastrup, 2011/08/24
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), Reinhold Kainhofer, 2011/08/24
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), Dan Eble, 2011/08/24
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), David Kastrup, 2011/08/24
- Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047), Dan Eble, 2011/08/24
Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047),
Han-Wen Nienhuys <=