lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Several fixes for annotate-spacing. (issue 4950071)


From: n . puttock
Subject: Re: Several fixes for annotate-spacing. (issue 4950071)
Date: Tue, 13 Sep 2011 10:14:50 +0000


http://codereview.appspot.com/4950071/diff/1/lily/page-layout-problem-scheme.cc
File lily/page-layout-problem-scheme.cc (right):

http://codereview.appspot.com/4950071/diff/1/lily/page-layout-problem-scheme.cc#newcode26
lily/page-layout-problem-scheme.cc:26: "Return the spacing spec going
between the two given grobs.")
between the two given grobs @var{from-scm} and @var{to-scm}.

http://codereview.appspot.com/4950071/diff/1/lily/page-layout-problem-scheme.cc#newcode28
lily/page-layout-problem-scheme.cc:28: LY_ASSERT_TYPE (unsmob_grob,
from_scm, 1);
LY_ASSERT_SMOB

http://codereview.appspot.com/4950071/diff/1/lily/page-layout-problem-scheme.cc#newcode29
lily/page-layout-problem-scheme.cc:29: LY_ASSERT_TYPE (unsmob_grob,
to_scm, 2);
LY_ASSERT_SMOB

http://codereview.appspot.com/4950071/diff/1/lily/skyline.cc
File lily/skyline.cc (right):

http://codereview.appspot.com/4950071/diff/1/lily/skyline.cc#newcode681
lily/skyline.cc:681: MAKE_SCHEME_CALLBACK (Skyline, get_touching_point,
3)
shouldn't this be

MAKE_SCHEME_CALLBACK_WITH_OPTARGS ?

http://codereview.appspot.com/4950071/diff/1/lily/skyline.cc#newcode699
lily/skyline.cc:699: MAKE_SCHEME_CALLBACK (Skyline, get_distance, 2)
MAKE_SCHEME_CALLBACK_WITH_OPTARGS ?

http://codereview.appspot.com/4950071/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]