|
| From: | n . puttock |
| Subject: | Re: Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord (issue 4969069) |
| Date: | Wed, 14 Sep 2011 19:58:41 +0000 |
LGTM. http://codereview.appspot.com/4969069/diff/2001/input/regression/laissez-vibrer-chords.ly File input/regression/laissez-vibrer-chords.ly (right): http://codereview.appspot.com/4969069/diff/2001/input/regression/laissez-vibrer-chords.ly#newcode1 input/regression/laissez-vibrer-chords.ly:1: \version "2.11.31" 2.15.12 http://codereview.appspot.com/4969069/diff/2001/lily/laissez-vibrer-engraver.cc File lily/laissez-vibrer-engraver.cc (right): http://codereview.appspot.com/4969069/diff/2001/lily/laissez-vibrer-engraver.cc#newcode66 lily/laissez-vibrer-engraver.cc:66: /* use the heard event_ for all noteheads, or an individual event for just note heads http://codereview.appspot.com/4969069/diff/2001/lily/laissez-vibrer-engraver.cc#newcode67 lily/laissez-vibrer-engraver.cc:67: * a single note-head (attached as an articulation inside a chord) */ note head http://codereview.appspot.com/4969069/
| [Prev in Thread] | Current Thread | [Next in Thread] |