Re: Implement optional music function arguments (issue 5023044)

[pkx166h]

Fails make
--snip--
Backtrace:
In unknown file:
   ?:  0* [primitive-load-path "documentation-generate.scm"]
In
/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/documentation-generate.scm:
  72:  1* [display ...
  73:  2*  [identifiers-doc-string]
In
/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm:
  64:  3   [format #f "@table @asis
~a
@end table
" ...
  69:  4*   [string-join ...
  70:  5*    [filter #<procedure identity (x)> ...
  72:  6*     [map #<procedure document-object (obj-pair)> (# # # #
...)]
In unknown file:
   ?:  7*     [document-object (acciaccatura . #)]
In
/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm:
 57:  8*     (cond (# #) (else #f))
  59:  9      [document-music-function (acciaccatura . #)]
  21: 10      (let* # #)

/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm:21:3:
In procedure memoization in expression (let* (# # # ...) (format #f
"@item @code{~a} ~a ~a~a
@funindex ~a
~a
" ...)):
/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm:21:3:
In file
"/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm",
line 29: Bad binding (type-names (map (lambda (pred) (if (pair? pred)
(format #f "[~a]" (type-name (car pred))) (format $f "(~a)" (type-name
pred))))) sign) in expression (let* ((name-sym (car music-func-pair))
(music-func (cdr music-func-pair)) (func (ly:music-function-extract
music-func)) (arg-names (map symbol->string (cddr (cadr
(procedure-source func))))) (doc (procedure-documentation func)) (sign
(object-property func (quote music-function-signature))) (type-names
(map (lambda (pred) (if (pair? pred) (format #f "[~a]" #) (format $f
"(~a)" #)))) sign) (signature-str (string-join (map (lambda (x) (format
#f "@var{~a} ~a" # #)) (zip arg-names (cdr type-names)))))) (format #f
"@item @code{~a} ~a ~a~a
@funindex ~a
~a
" name-sym (car type-names) (if (equal? "" signature-str) "" " - ")
signature-str name-sym (if doc doc (begin (ly:warning "music function
`~a' not documented." name-sym) "(undocumented; fixme)")))).
make[1]: *** [out/internals.texi] Error 1
make[1]: Leaving directory
`/home/jlowe/lilypond-git/build/Documentation'
make: *** [all] Error 2
address@hidden:~/lilypond-git/build$


http://codereview.appspot.com/5023044/