lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New alist to replace special characters. (issue 4553056)


From: n . puttock
Subject: Re: New alist to replace special characters. (issue 4553056)
Date: Wed, 21 Sep 2011 21:10:09 +0000


http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly
File Documentation/included/special-characters.ly (right):

http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly#newcode1
Documentation/included/special-characters.ly:1: \version "2.15.12"
2.15.13

http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly#newcode8
Documentation/included/special-characters.ly:8:
#(define-markup-list-command (show-special-characters layout props) ()
fix indentation (nearly every line)

http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly#newcode13
Documentation/included/special-characters.ly:13: #:override
'(replacement-alist . ()) (car pair)
indentation is artificially compressed (aligns with the dangling
parenthesis)

http://codereview.appspot.com/4553056/diff/106003/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4553056/diff/106003/Documentation/notation/input.itely#newcode1762
Documentation/notation/input.itely:1762: \new Staff { \repeat unfold 9
a' }
a'4

http://codereview.appspot.com/4553056/diff/106003/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):

http://codereview.appspot.com/4553056/diff/106003/Documentation/notation/notation-appendices.itely#newcode912
Documentation/notation/notation-appendices.itely:912: The rest of them
are inspired of LaTeX.
inspired by @LaTeX{}

http://codereview.appspot.com/4553056/diff/106003/input/regression/markup-special-characters.ly
File input/regression/markup-special-characters.ly (right):

http://codereview.appspot.com/4553056/diff/106003/input/regression/markup-special-characters.ly#newcode1
input/regression/markup-special-characters.ly:1: \version "2.15.12"
2.15.13

http://codereview.appspot.com/4553056/diff/106003/input/regression/markup-special-characters.ly#newcode4
input/regression/markup-special-characters.ly:4: A list of special
characters ASCII aliases can be easily included.
character

http://codereview.appspot.com/4553056/diff/106003/input/regression/markup-special-characters.ly#newcode5
input/regression/markup-special-characters.ly:5: This works for markups
and lyrics.
remove leading spaces

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc
File lily/text-interface.cc (right):

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode43
lily/text-interface.cc:43: if (!to_boolean (scm_list_p
(replacement_alist))
!ly_is_list

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode44
lily/text-interface.cc:44: || to_boolean (scm_null_p
(replacement_alist)))
scm_is_null

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode51
lily/text-interface.cc:51: (scm_string_length (scm_caar (s))));
fix indent (run through fixcc.py)

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode56
lily/text-interface.cc:56: for (int j = max_length; j > 0; j--)
(vsize j = max_length; j--;)

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode60
lily/text-interface.cc:60: (ly_assoc_get (ly_string2scm (dummy),
fix indent

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode61
lily/text-interface.cc:61: replacement_alist, SCM_BOOL_F), "");
fix indent

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly
File ly/text-replacements.ly (right):

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode20
ly/text-replacements.ly:20: #(define (add-text-replacements! alist)
fix indentation

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode26
ly/text-replacements.ly:26: (add-text-replacements!
fix indentation

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode27
ly/text-replacements.ly:27: '(; Punctuation
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode36
ly/text-replacements.ly:36: ; French, German and English quotes
open/close
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode50
ly/text-replacements.ly:50: ; Word dividers
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode60
ly/text-replacements.ly:60: ; General typography
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode77
ly/text-replacements.ly:77: ; Diacritics
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode88
ly/text-replacements.ly:88: ; Non-ASCII Letters (Excluding Accented
Letters)
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode110
ly/text-replacements.ly:110: ; Mathematical symbols
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode127
ly/text-replacements.ly:127: ; Currency symbols
;;

http://codereview.appspot.com/4553056/diff/106003/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4553056/diff/106003/scm/define-grob-properties.scm#newcode685
scm/define-grob-properties.scm:685: The key is a string of the pattern
to be replaced. The value is a
two spaces following full stop/period

http://codereview.appspot.com/4553056/diff/106003/scm/define-grob-properties.scm#newcode686
scm/define-grob-properties.scm:686: string of what should be displayed.
Useful for ligatures.")
two spaces following full stop/period

http://codereview.appspot.com/4553056/diff/106003/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/4553056/diff/106003/scm/define-markup-commands.scm#newcode2161
scm/define-markup-commands.scm:2161: layout
indent (one space)

http://codereview.appspot.com/4553056/diff/106003/scm/define-markup-commands.scm#newcode2163
scm/define-markup-commands.scm:2163: `((baseline-skip . ,(*
magnification ref-baseline))
indent (one space)

http://codereview.appspot.com/4553056/diff/106003/scm/define-markup-commands.scm#newcode2187
scm/define-markup-commands.scm:2187: layout
indent

http://codereview.appspot.com/4553056/diff/106003/scm/define-markup-commands.scm#newcode2189
scm/define-markup-commands.scm:2189: `((baseline-skip . ,(*
baseline-skip (magstep increment)))
indent

http://codereview.appspot.com/4553056/diff/106003/scm/define-markup-commands.scm#newcode3714
scm/define-markup-commands.scm:3714: layout
indent

http://codereview.appspot.com/4553056/diff/106003/scm/define-markup-commands.scm#newcode3716
scm/define-markup-commands.scm:3716: props
indent

http://codereview.appspot.com/4553056/diff/106003/scm/output-lib.scm
File scm/output-lib.scm (right):

http://codereview.appspot.com/4553056/diff/106003/scm/output-lib.scm#newcode996
scm/output-lib.scm:996: ;; text replacements
These are misplaced here.  output-lib.scm is for grob callbacks.

http://codereview.appspot.com/4553056/diff/106003/scm/output-lib.scm#newcode999
scm/output-lib.scm:999: '(; Whitespaces
;; (`;' is for margin comments)

fix indent

http://codereview.appspot.com/4553056/diff/106003/scm/output-lib.scm#newcode1007
scm/output-lib.scm:1007: (append dummy-replacements alist)))
indent

http://codereview.appspot.com/4553056/diff/106003/scm/output-lib.scm#newcode1008
scm/output-lib.scm:1008: (prepend-alist-chain 'replacement-alist
new-replacements props)))
indent (aligns with `e' in let*)

http://codereview.appspot.com/4553056/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]