[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Improves some parmesan noteheads. (issue 4639065)

From: k-ohara5a5a
Subject: Re: Improves some parmesan noteheads. (issue 4639065)
Date: Mon, 03 Oct 2011 04:57:59 +0000
File lily/ (right):
lily/ }
Yuck.  The decision tree is complex enough that two tests of font
capability seem to be required for the most common case; that will be
slow on Windows if the tests require font-lookups.

Caching would help, but if it complicates the code then future changes
will be harder.

Best would be to use the same method as shape-notes, where the engraver
determines the part of glyph name that depends on pitch.

Alternatively, use a property of NoteHead, along-side of 'style', to
indicate if a reduced-hole version is expected in the font, and look for
the glyph only when property says to expect it.
File lily/ (right):
lily/ extract_grob_set (me, "note-heads", heads);
'f' already points to the first head; why not just use that?
lily/ if (attach && !scm_is_eq (style, ly_symbol2scm
To adjust the attach points, shouldn't you adjust charwx in the font?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]