[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New git cl :: rebase patches

From: Colin Campbell
Subject: Re: New git cl :: rebase patches
Date: Tue, 04 Oct 2011 07:04:25 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 11-10-04 02:48 AM, address@hidden wrote:
Hey all,

I uploaded a couple patches to Rietveld this morning just to have clean diffs 
with current master (my bazillion commits on my local branch won't apply to 
current master anymore).  I then download this diff and run the regtests.  
However, with the new git cl, James sees patch_new and also runs the regtests.  
Thus, he may be running failing retgetsts that I haven't been able to check 
yet.  I think that the new git cl should ask the uploader if she wants a patch 
to be labeled patch new instead of doing it automatically so that James doesn't 
run regtests on patches that could be buggy.  Thoughts?


How about patch status of "WIP", for "work in progress", or we could have the patch status default to needs-work, with the onus on the developer to set it to patch-new when it's ready to be checked?


I've learned that you shouldn't go through life with a catcher's mitt on both 
You need to be able to throw something back.
-Maya Angelou, poet (1928- )

reply via email to

[Prev in Thread] Current Thread [Next in Thread]