[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Sketch for in-notes. (issue 5293053)

From: bordage . bertrand
Subject: Re: Sketch for in-notes. (issue 5293053)
Date: Fri, 21 Oct 2011 11:52:25 +0000

I can't compile because of valgrind.

File lily/include/page-layout-problem.hh (right):
lily/include/page-layout-problem.hh:100: Direction in_note_direction_;
Trailing whitespace.
File lily/ (right):
lily/ old.in_note_heights_.begin (),
old.in_note_heights_.end ());
Check the length of these lines of code.
lily/ in_note_padding_ = robust_scm2double
(pb->paper_->c_variable ("in-note-padding"), 0.0);
Same comment as before.
File lily/ (right):
lily/ if (lines == SCM_EOL)
if (!scm_is_pair (lines))

See the new chapter "Scheme->C interface" in CG/Programming work.
Trailing whitespace.
lily/ footnotes_added = g->get_property
("footnote-stencil") != SCM_EOL;
footnotes_added = scm_is_pair (g->get_property ("footnote-stencil"));
lily/ footnotes_added = p->get_property
("footnote-stencil") != SCM_EOL;
Same as before.
lily/ in_note_mol.add_at_edge (Y_AXIS, DOWN,
*footnote_stencil, padding);
Check the line length.
lily/ #include <valgrind/valgrind.h>
lily/ in_note_padding_ = robust_scm2double
(paper->c_variable ("in-note-padding"), 0.5);
Line length.
lily/ in_note_direction_ = UP;
You could use robust_scm2dir instead of these three lines.
lily/ Stencil *in_note_stencil =
unsmob_stencil (sys->get_property ("in-note-stencil"));
Line length.
lily/ sky->set_minimum_height
(sky->max_height () + in_note_direction_ * (in_note_padding_ +
in_note_stencil->extent (Y_AXIS).length ()));
Line length.
File lily/ (right):
lily/ bool has_in_notes;
Shouldn't it be has_in_notes_ (with an underscore at the end)?
has_footnotes_ should be defined here too.
lily/ in_note_height += (has_in_notes
What is the default value of an unset boolean?  I mean: the first time,
is it adding 0.0 or breaker_->in_note_padding()?
lily/ : breaker_->in_note_padding ());
Trailing whitespace.
File lily/ (right):
lily/ System::internal_get_note_heights_in_range (vsize
start, vsize end, bool foot)
Ugh...  A boolean to tell if we're in a footnote or in an "in-note"...
lily/ if (foot ? !to_boolean
(footnote_grobs[i]->get_property ("footnote")) : to_boolean
(footnote_grobs[i]->get_property ("footnote")))
Line length.  Plus, I don't really understand what's the use of this.
File scm/define-grob-properties.scm (right):
scm/define-grob-properties.scm:299: (footnote ,boolean? "Should this be
a footnote or in-note?")
Again, this is really ugly.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]