[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: convert-ly rules to destencil Flags

From: address@hidden
Subject: Re: convert-ly rules to destencil Flags
Date: Mon, 24 Oct 2011 17:34:11 +0200

On Oct 24, 2011, at 5:29 PM, David Kastrup wrote:

> "address@hidden" <address@hidden> writes:
>> On Oct 24, 2011, at 5:12 PM, David Kastrup wrote:
>>> "address@hidden" <address@hidden> writes:
>>>> On Oct 24, 2011, at 4:29 PM, David Kastrup wrote:
>>>>> Mike has pushed directly 671b7b63408893c33b4c1f196e87db19a7dbcd1e to
>>>>> master, as far as I can see without any discussion and without going
>>>>> through staging.
>>>> This got to patch push after going through a countdown.
>>> Ok, so my mistake, and the only one not following rules at all am I.
>>> The problem is that to do a full review of convertrules means actually
>>> _applying_ them and looking at the results (including testing them, but
>>> also checking visually).  Which does not appear to have happened here.
>> I did this on a test file and did not see any problems.  I did not run
>> it on the docs because, as you pointed out, I updated everything
>> manually before the idea came to me to write this rule (which only
>> governs a certain easy case - other stencil overrides are not
>> convert-ly-able).
> The problem is that eventually, somebody else _will_ run
> scripts/auxiliar/update-with-convert-ly and then those files get fixed
> "again" if the version string indicates they have not yet been fixed.
> I am currently stalled exactly because running this script as part of
> _my_ changes will change a number of files which are none of my beeswax.

I'll be able to post a patch to fix this w/in the next 18ish hours.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]