[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Sketch for broken beams with consistent slopes (issue 4961041)

From: k-ohara5a5a
Subject: Re: Sketch for broken beams with consistent slopes (issue 4961041)
Date: Wed, 26 Oct 2011 18:57:38 +0000

Rather indecipherable.

The 350 lines of code re-ordering make it difficult to find the change
in function.  Therefore I am not willing to say LGTM, and looks like
nobody else was, either.

It looks like the intent is, if consistent_broken_slope=#t, to join the
parts of a broken beam together and present the combination to
Beam_scoring_problem, but...
File lily/ (right):
lily/ for (vsize i = 0; i < beams.size (); i++)
When there is more than one beam in 'beams' what do you intend the
members Beam_scoring_problem to represent ?  The beam as if it were on
one line, but allowing the extra horizontal span due to the line-break ?
 Should the members like segments_ and is_knee_ include both halves of
the beam ?
lily/ final_positions[RIGHT] -= (1 -
normalized_endpoints[RIGHT]) * y_length;
At what horizontal locations are these final_positions? First and last
stems or the end of the beam including overhang or x_span_ ?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]