[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

From: Phil Holmes
Subject: Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)
Date: Mon, 31 Oct 2011 14:19:55 -0000

----- Original Message ----- From: <address@hidden>
To: <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Monday, October 31, 2011 9:08 AM
Subject: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

Reviewers: ,

Hey all,

This fixes the SpanBar regression ID'd by Phil.  It also fixes a few
other things:

1) The research I sent out about accidentals not hanging over barlines
(check my e-mails to the list from Oct. 6, Subject: First stab at
getting bar extents right) is actualized here.
2) The elimination of skyline-vertical-padding corrects a horizontal
spacing issue where the cue-clef takes up too much space in and
3) A new regtest,, shows a bug fix for lyrics.

The patch passes regtests (I have yet to do a full doc build).  The only
concern I have is that a lot of regtests that combine tablature and
normal notation are effected but I cannot see how (lots of green, but
nothing looks like it moved).  I don't know why my code is doing this,
and I'm always hesitant to push code that has an effect that I could
neither predict nor explain.  I'll have time to look into it on
Wednesday-ish.  Meanwhile, if anyone has any ideas about what this could
come from, they're welcome!


Fixes NoteColumn vs SpanBar collisions.

Please review this at

Affected files:
  M lily/include/pure-from-neighbor-interface.hh
  M lily/
  M lily/
  M scm/output-lib.scm

Mike - do you have a Windows machine? And a Windows .exe for your changes? If so, you could run my pixel comparator.

Phil Holmes

reply via email to

[Prev in Thread] Current Thread [Next in Thread]