[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Work on 1890: Fix several compiler warnings on amd64 platform (chang
Re: Work on 1890: Fix several compiler warnings on amd64 platform (changing variable types) (issue 5039043)
Tue, 01 Nov 2011 00:37:20 +0000
Looks fine to me.
The type ssize_t is unusual, but it was already in the code before this
File flower/polynomial.cc (right):
flower/polynomial.cc:332: Polynomial::degree ()const
This one would be better as a cast to int, because it is an interface
function, and allowing for polynomials of degree greater than 2Billion
is just too weird.