[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Fixes to jazz chord displays (issue 5320074)

From: Carl . D . Sorensen
Subject: Fixes to jazz chord displays (issue 5320074)
Date: Thu, 03 Nov 2011 23:33:27 +0000

Reviewers: ,

I've uploaded Adam's changes for review.

I removed the spacing changes in scm/chord-ignatzek-names.scm awaiting
resolution on .scm indentation.

Fixes to jazz chord displays

This issue consists of a well-formed series of commits created by Adam

The commits are independent; each commit modifies a different set of
If the complete patch set builds, each of the individual commits should
build.  I have not tested them, but I've read them carefully and judge
that the risk is low enough to review the complete set.

I have removed the .scm file reformatting from this patch set, as
the final definition of our .scm format is not yet agreed upon.
our policy is to leave spacing as is until we have agreed.

Issue 1503 - add support for "altered" jazz chord (super-Locrian)

fix indentation in chord-ignatzek-names.scm

Doc: fix spurious pluralisation typo in Chord name chart appendix

Issue 1503 - add additionalPitchPrefix to allow choice of prefix for
additional pitches in chords.

This was previously "add", e.g. "Cmaj7 add6add9",
but this results in too much clutter and
is rarely used.

Issue 1503 - Allow choice of minor chord modifier.

For example, often it is preferred to use a hyphen
instead of "m". This can now be achieved via:

  \set minorChordModifier = \markup { "-" }

add slashChordSeparator

Issue 1572 and issue 1503 - Allow choice of
chord modifier separator independently of
chord inversion separator, since conventionally
the latter is always a slash (hence the term
"slash chords"), whereas the former seldom
involves slashes.

add some missing chords to the ignatzek regression test

Issue 1503 - Recognise Lydian chords

enlarge half-diminished slashed circle symbol

Please review this at

Affected files:
  M Documentation/included/
  M Documentation/notation/chords.itely
  M Documentation/notation/notation-appendices.itely
  A input/regression/
  A input/regression/
  A input/regression/
  M input/regression/
  M ly/
  M ly/
  M scm/chord-ignatzek-names.scm
  M scm/define-context-properties.scm

reply via email to

[Prev in Thread] Current Thread [Next in Thread]