Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

[mtsolo]

http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc
File lily/pure-from-neighbor-interface.cc (right):

http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc#newcode84
lily/pure-from-neighbor-interface.cc:84: // uses drul array for grace
(LEFT) vs. not grace (RIGHT).
On 2011/11/07 01:25:30, Keith wrote:
> Why use a drul array instead of just an array from 0 (false) to 1
(true) indexed
> by your boolean 'has_grace' ?

This is a good idea - will do.

http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc#newcode96
lily/pure-from-neighbor-interface.cc:96: && (grace == LEFT ? has_grace :
!has_grace))
On 2011/11/07 01:25:30, Keith wrote:
> In fact, why even use a loop over grace-ness if the actions within the
loop
> occur only for one of two passes through ?

I'm not sure what you mean...the actions apply for both passes.

http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc#newcode113
lily/pure-from-neighbor-interface.cc:113: if (d * srl_drul[LEFT][d] < d
* srl_drul[RIGHT][d])
On 2011/11/07 01:25:30, Keith wrote:
> This seems to say "if the closest grace-note-column is closer than the
closest
> non-grace-column, include the stuff in the grace-note-column in my
'neighbors'".
> Why are you treating grace-note columns specially ?

This is saying "if the closest column is a grace-note-column, include
the next-closest column as well."  This gets rid of any accidental
overlap problems at the expense of potentially adding a little extra
vertical space to the page-spacer calculations, but this extra space
seems to be so minimal as to not be a problem (not unlike pure heights
for beamed stems, which could also slightly overshoot their actual
height).

http://codereview.appspot.com/5323062/