lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Give slurs skylines in outside-staff-priority calculations. (issue 5


From: n . puttock
Subject: Re: Give slurs skylines in outside-staff-priority calculations. (issue 5504055)
Date: Wed, 28 Dec 2011 17:30:19 +0000


http://codereview.appspot.com/5504055/diff/3002/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/5504055/diff/3002/scm/define-grob-properties.scm#newcode1101
scm/define-grob-properties.scm:1101: (skyline-quantizing ,ly:vsize? "The
number of boxes to break a
Mike, why have you added this predicate?  It has no analogue in Scheme.
I think integer? would be fine for this.  You can silently prevent
negative numbers.

http://codereview.appspot.com/5504055/diff/3002/scm/define-grob-properties.scm#newcode1102
scm/define-grob-properties.scm:1102: slur into when calculating its
skyline.")
I think this should be more generic.  There are other objects which
would benefit from this such as hairpins and text spanners.

http://codereview.appspot.com/5504055/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]