[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Removes ugly side bars from learning (issue 5498089)
From: |
graham |
Subject: |
Re: Removes ugly side bars from learning (issue 5498089) |
Date: |
Thu, 29 Dec 2011 18:01:04 +0000 |
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/common-notation.itely
File Documentation/learning/common-notation.itely (right):
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/common-notation.itely#newcode853
Documentation/learning/common-notation.itely:853: <c e g>\>[ <c f a> <c
f a> <c e g>]\! |
On 2011/12/29 13:42:10, J_lowe wrote:
If we're breaking a line then should we re-state the duration.
I.e. <c e g>8\>[ <c ...
I'm not too fussed about that, but the second line should be indented by
two spaces to indicate that it's a continuation of the previous line
(i.e. not starting its own bar). I certainly wouldn't object to having
an explicit duration, though!
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/templates.itely
File Documentation/learning/templates.itely (right):
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/templates.itely#newcode162
Documentation/learning/templates.itely:162:
@lilypondfile[verbatim,quote,ragged-right,texidoc,line-width=140]
On 2011/12/29 13:42:10, J_lowe wrote:
Is any merit in preference to editing the snippet than forcing the
issue in the
Tex code within the itely file?
I'm not fond of having an explicit line-width. Could this be done by
either editing the snippet, or giving a papersize option instead?
I still think that it's a general bug if non-insane .ly code exceeds the
bounds of the box, but I can't remember where we ended up in those
bugfixes Reinhold was doing IIRC half a year ago.
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
http://codereview.appspot.com/5498089/diff/1/Documentation/learning/tweaks.itely#newcode4022
Documentation/learning/tweaks.itely:4022:
@address@hidden/LilyPond.app/Contents/Resources/share/lilypond/current/}
Please make this an
@example
instead. The @* syntax is really icky; I think we should only use it if
there's no other way of getting what we want (i.e. forcing a line-break
inside a @warning{} macro, which unfortunately does not allow normal
line breaks).
http://codereview.appspot.com/5498089/