[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: some comments and complaints on the code (issue 5651069)
From: |
joeneeman |
Subject: |
Re: some comments and complaints on the code (issue 5651069) |
Date: |
Mon, 13 Feb 2012 03:36:27 +0000 |
http://codereview.appspot.com/5651069/diff/1/lily/accidental-placement.cc
File lily/accidental-placement.cc (right):
http://codereview.appspot.com/5651069/diff/1/lily/accidental-placement.cc#newcode211
lily/accidental-placement.cc:211: * @return A vector of
Accidental_placement_entrys
On 2012/02/11 12:27:31, Milimetr88 wrote:
Do you mean @param and @return or the comment to the function? What
comment
would you propose?
I'm complaining about the @return comment, since it's redundant (ie. no
need to change it, just remove that line). I'm ok with the @param
comment, because you can't tell from the function signature that accs is
supposed to be a list.
http://codereview.appspot.com/5651069/
- Re: some comments and complaints on the code (issue 5651069), (continued)
- Re: some comments and complaints on the code (issue 5651069), janek . lilypond, 2012/02/11
- Re: some comments and complaints on the code (issue 5651069), milimetr88, 2012/02/11
- Re: some comments and complaints on the code (issue 5651069), janek . lilypond, 2012/02/11
- Re: some comments and complaints on the code (issue 5651069), k-ohara5a5a, 2012/02/11
- Re: some comments and complaints on the code (issue 5651069),
joeneeman <=
- Re: some comments and complaints on the code (issue 5651069), hanwenn, 2012/02/13
- Re: some comments and complaints on the code (issue 5651069), hanwenn, 2012/02/13
- Re: some comments and complaints on the code (issue 5651069), janek . lilypond, 2012/02/16