[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Gets vertical skylines from grob stencils (issue 5626052)

From: joeneeman
Subject: Re: Gets vertical skylines from grob stencils (issue 5626052)
Date: Thu, 16 Feb 2012 08:09:10 +0000
File lily/ (right):
lily/ vector<Grob *> *riders)
I don't understand why riders are necessary. Is it because of this
cyclic dependence stuff?
File lily/ (right):
lily/ Strips all old sloped material, adds new.
You're assuming that all sloped material came from skyline padding.
That's true right now, but there's no reason that it will continue to be
true. It's probably better to avoid adding padding at creation time
altogether, and instead to add it when calling Skyline::distance.
lily/ Skyline::left () const
This is linear in the number of buildings, but it should be constant.
lily/ Skyline::right () const
File lily/ (right):
lily/ SCM glyph_info = scm_hashq_ref (font_list,
scm_string_to_symbol (glyph), SCM_EOL);
There isn't much error-checking here. What if the user substitutes an
unofficial font which isn't in the list?

By the way, lilypond's fonts embed extra data in font tables (look for
LILC and LILY in That may be a better way to embed
this information than by putting it in a scm file. For example, it would
allow unofficial fonts to support integrals by embedding an extra table.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]