[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fix mordents and pralltriller in articulate.ly (issue 5829043)
From: |
graham |
Subject: |
Fix mordents and pralltriller in articulate.ly (issue 5829043) |
Date: |
Thu, 15 Mar 2012 00:49:01 +0000 |
looks basically good, but two minor points.
Make that three minor points: please CC to -devel, not -devl.
http://codereview.appspot.com/5829043/diff/1/ly/articulate.ly
File ly/articulate.ly (right):
http://codereview.appspot.com/5829043/diff/1/ly/articulate.ly#newcode482
ly/articulate.ly:482: (let ((pset (make-music 'PropertySet
The indentation looks a bit off, but we don't have a tool for scheme
indentation, nor do we even have any consistency in terms of spaces vs.
tabs in .scm files, so good enough for me.
http://codereview.appspot.com/5829043/diff/1/ly/articulate.ly#newcode625
ly/articulate.ly:625: (else music))
extra space?
http://codereview.appspot.com/5829043/diff/1/ly/articulate.ly#newcode630
ly/articulate.ly:630: % At last ... here's the music function that
aplies all the above to a
this adds a typo?
http://codereview.appspot.com/5829043/
- Fix mordents and pralltriller in articulate.ly (issue 5829043),
graham <=