[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes heights and pure heights of stems. (issue 4898044)

From: Keith OHara
Subject: Re: Fixes heights and pure heights of stems. (issue 4898044)
Date: Tue, 27 Mar 2012 00:21:47 -0700
User-agent: Opera Mail/11.61 (Win32)

On Mon, 26 Mar 2012 23:14:15 -0700, Mike Solomon <address@hidden> wrote:

 The code in lily/ needs an update to adjust the
stem beginning (issue 2441).  I tried but I can't find the "pure
callback for stem beginnings".


Okay, it is actually the not-pure version that causes trouble.

When internal_calc_stem_begin_position (Grob *me, bool calc_beam)
is called to actually print the stems, calc_beam is true, and
+  if (beam && calc_beam)
+    {
+      (void) beam->get_property ("quantized-positions");
+      return me->extent (me, Y_AXIS)[-get_grob_direction (me)] * ss * 2;
+    }
returns an answer that does not include the results of
  Real y_attach = Note_head::stem_attachment_coordinate (head, Y_AXIS);

It seems that the /begin/ positions, the positions of the stem-ends attached to 
the note heads, should be calculated the old way whether the beam placement has 
been determined or not, so I'm inclined to remove if() above, removing the need 
for a pure_* version of calc-stem-begin-position.

Lemme know if I can be of help w/ fixing this!

I'd rather you did.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]