[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Corrected comments and a function check_meshing_chords divided in two. (
Corrected comments and a function check_meshing_chords divided in two. (issue 5975054)
Sat, 31 Mar 2012 21:04:35 +0000
LGTM, except that it confuses the two programs we have used recently for
automatic code indentation.
File flower/include/direction.hh (right):
flower/include/direction.hh:90: for (Direction d = UP; d != CENTER;
flip(&d), d == UP ? d = CENTER : d)
It is still difficult to understand.
for (Direction d = UP; d != CENTER; d = (UP == d)? DOWN, CENTER)
File lily/note-collision.cc (right):
lily/note-collision.cc:45: /* Filter out the 'o's in this configuration,
since they're no
Keith, I'm trying to understand the whole function and
divide it into parts.
Does this comment refer only to the two lines below?
It explains the two assignment lines below. We use the results of those
assignments, the filtered arrays of note-heads, for the rest of the
Therefore you don't need to pass 'ups' and 'dps' as arguments in to this
lily/note-collision.cc:404: for_UP_and_DOWN (d)
The code-indenting program we use
is not smart enough to determine that this macro starts a control block,
so it indents the code as if for_UP_and_DOWN was a function call or
The indenter in emacs does the same.
If you write the 'for' loop directly in the code, then neither humans
nor auto-indent programs need to learn a macro:
for (Direction d = UP; d; d = (UP == d)? DOWN : CENTER)
|[Prev in Thread]
||[Next in Thread]|
- Corrected comments and a function check_meshing_chords divided in two. (issue 5975054),