[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Brings beamed rest closer to cross staff beam. (issue 5908043)

From: mike
Subject: Re: Brings beamed rest closer to cross staff beam. (issue 5908043)
Date: Wed, 25 Apr 2012 11:14:42 +0000

On 2012/04/25 11:10:40, Milimetr88 wrote:
File lily/ (right):
lily/ || beam->get_property_data ("direction") ==
On 2012/04/25 06:29:14, mike7 wrote:
> On 2012/04/25 06:21:54, Keith wrote:
> > Mike, any idea why you added this?
> > It just adds to the cases where we lie and say the beam is on the
> > It causes this to go wrongly
> > << {b''8[ r16. g''32] } \\ {r8 <f' g' a' b'>16. r } >>
> >
> > Take a look at today's patchset at
> >
> If this bit isn't there, a circular dependency could be called up
later on in
> the function while looking for the direction.  I forget the exact
reason for
> circular dependency, but it crept up in several regtests.  Like
several other
> pure functions, I have it cowardly fail if a pure estimation is not
> because of circular dependencies, which usually has a minimal impact
on the
> typeset result.

I'm not well-placed to say.  I try to let the code act as its own
commentary as much as possible.  Here, I think that a person who knows
the code base knows that if the function exits because a property's
calculation is in progress, it is to avoid triggering that calculation.
However, if anyone feels that this is not pick-upable upon reading,
please add the comment!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]