Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

[k-ohara5a5a]

Absorbed suggestions.  Added snippets.


http://codereview.appspot.com/6197068/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

http://codereview.appspot.com/6197068/diff/1/Documentation/notation/changing-defaults.itely#newcode749
Documentation/notation/changing-defaults.itely:749: s1^"Small, thicker
stems, no time signature"
On 2012/05/13 19:06:43, dak wrote:
> I don't like this. [...] no longer copy-and-paste material.

I don't like it either.  The the original was not foolproof
copy-and-paste either, with the duration leakage.

http://codereview.appspot.com/6197068/diff/1/Documentation/notation/keyboards.itely
File Documentation/notation/keyboards.itely (right):

http://codereview.appspot.com/6197068/diff/1/Documentation/notation/keyboards.itely#newcode210
Documentation/notation/keyboards.itely:210: e''2\p\< d''\> | c''1\!
This example is rather dense.  Any other way of defusing the s1*0
problem is distracting, as was the s1*0 itself.

http://codereview.appspot.com/6197068/diff/1/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

http://codereview.appspot.com/6197068/diff/1/Documentation/notation/pitches.itely#newcode1401
Documentation/notation/pitches.itely:1401: s1^\markup { Switch to B\flat
clarinet }
On 2012/05/13 19:06:43, dak wrote:
> The markup can't just be attached to the whole bar rest?

No, because we need the textLengthOn to have effect.  Multimeasure
rests, and their text scripts, have special spacing rules.

The s1, however, splits a compressed multi-measure rest R1*12 into R1
R1*11.

I cannot recommend in good conscience anything but <> here.

http://codereview.appspot.com/6197068/diff/1/Documentation/notation/staff.itely
File Documentation/notation/staff.itely (right):

http://codereview.appspot.com/6197068/diff/1/Documentation/notation/staff.itely#newcode1361
Documentation/notation/staff.itely:1361: \new CueVoice { \set
"instrumentCueName" = "flute" }
On 2012/05/13 19:06:43, dak wrote:
>   Perhaps we should instead let \cueDuring accept an optional context
> modification argument.
Xavier requested this optional argument to \cueDuring, but Trevor has
had a \cueWhile function in the docs for a while, which takes a string
to identify who is giving the cue, so I think it best to stick with
that.

http://codereview.appspot.com/6197068/diff/10002/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):

http://codereview.appspot.com/6197068/diff/10002/Documentation/notation/simultaneous.itely#newcode90
Documentation/notation/simultaneous.itely:90: { f'4 <>\marcato \music r
<>^"smorz." \mp \> \music <>\! }
maybe this is a better example.

http://codereview.appspot.com/6197068/