[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Narrowly target warnings for multiple slurs; Issue 1967 (issue 62720
Re: Narrowly target warnings for multiple slurs; Issue 1967 (issue 6272046)
Wed, 06 Jun 2012 06:24:22 +0000
File lily/slur-engraver.cc (right):
lily/slur-engraver.cc:174: bool ended = false;
On 2012/06/05 12:04:36, dak wrote:
Moving this out of the loop is simply wrong. This will get a warning
_all_ closing events don't have an associated starting event
regardless of the
spanner-id. This needs to be done more carefully instead of just
code until it stops giving warnings.
Thanks, I think.
We could simply move this initializer back where it was, and issue 1967
would still be as "fixed" as much as it is in current master.
I think it would be clearest to have a separate loop through
stop_events_ at this point to remove redundant ')'s with duplicate
'spanner-id's. Then that whole loop could go when partcombine is
improved. But I won't be running Linux to test the code for a day or so.