[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Footnotes correctly printed on grobs at first timestep. (issue 63060
From: |
dak |
Subject: |
Re: Footnotes correctly printed on grobs at first timestep. (issue 6306064) |
Date: |
Sun, 10 Jun 2012 16:24:52 +0000 |
http://codereview.appspot.com/6306064/diff/1/input/regression/footnote-break-visibility.ly
File input/regression/footnote-break-visibility.ly (right):
http://codereview.appspot.com/6306064/diff/1/input/regression/footnote-break-visibility.ly#newcode21
input/regression/footnote-break-visibility.ly:21: \once \override Score
. FootnoteItem #'break-visibility = ##(#f #f #t)
This looks like an unrelated fix that should just get pushed to staging
independently. I am surprised that it did not show in the regtest
comparison.
http://codereview.appspot.com/6306064/diff/1/lily/system.cc
File lily/system.cc (right):
http://codereview.appspot.com/6306064/diff/1/lily/system.cc#newcode257
lily/system.cc:257: end_of_line_visible = item->break_status_dir () ==
LEFT;
While I readily admit that this is breaking with the traditions set
forth in the existing code, could you add a comment about what you are
doing here?
http://codereview.appspot.com/6306064/diff/1/lily/system.cc#newcode280
lily/system.cc:280: if (find (out.begin (), out.end (), at_bat) !=
out.end ())
And here? Thanks.
http://codereview.appspot.com/6306064/