[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Sets TabVoice Stem height to ##f (issue 6303065)

From: k-ohara5a5a
Subject: Re: Sets TabVoice Stem height to ##f (issue 6303065)
Date: Mon, 11 Jun 2012 16:33:27 +0000

LGTM if you re-read the comment before you push.
File lily/ (right):
lily/ return an empty interval when there is no beam.
The comment doesn't exactly match the code (we the full stem interval
for the imaginary stems on beamed rests, not just a point) so take
another read before you push.  Maybe let the code show what you do, and
just say why you do it.  "If there is a beam but no stem, slope
calculations depend on this routine to return where the stem end /would/
lily/ if (calc_beam && !beam && !unsmob_stencil
(me->get_property ("stencil")))
If you have time to test the output, consider removing the test for
calc_beam, and combining with similar line 692.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]