lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1320: Scheme bar line interface (issue 6305115)


From: Marc Hohl
Subject: Re: Issue 1320: Scheme bar line interface (issue 6305115)
Date: Thu, 21 Jun 2012 11:05:45 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

Am 21.06.2012 08:35, schrieb Marc Hohl:
Am 20.06.2012 21:34, schrieb address@hidden:

http://codereview.appspot.com/6305115/diff/1/scm/bar-line.scm
File scm/bar-line.scm (right):

http://codereview.appspot.com/6305115/diff/1/scm/bar-line.scm#newcode83
scm/bar-line.scm:83: (define (make-colon-bar-line grob)
I'm afraid this defun doesn't match the relevant part of current
Bar_line::compound_barline.

try

\new Staff {
\override Staff.StaffSymbol #'line-positions = #'(-2 0 2 4)
s1 \bar ":|"
}
Thanks for the hint! I didn't check the results with altered line positions yet,
but I don't understand what's wrong here – IMHO the scheme stuff mimics
1:1 the code from the original definition.

What is wrong here?
After some research, I found of that line-count is wrong,
I get a value of 5 instead of 4!

So something along

 (let* ((staff-symbol (ly:grob-object grob 'staff-symbol))
         (line-count (if (ly:grob? staff-symbol)
                         (ly:grob-property staff-symbol 'line-count)
                         0))
...

is fishy

http://codereview.appspot.com/6305115/







reply via email to

[Prev in Thread] Current Thread [Next in Thread]