Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

[john . mandereau]

Reviewers: Graham Percival,

Message:
I'm on submitting another patchset (later tonight).


http://codereview.appspot.com/6354044/diff/1/Documentation/contributor/administration.itexi
File Documentation/contributor/administration.itexi (right):

http://codereview.appspot.com/6354044/diff/1/Documentation/contributor/administration.itexi#newcode271
Documentation/contributor/administration.itexi:271: 02 0-23/2 * * *
/bin/bash -lc
/home/patchy/git/lilypond-extra/patches/lilypond-patchy-staging.py
On 2012/06/27 10:11:33, Graham Percival wrote:
> For the website on http://lilypond.org, I have this in my crontab:


> # website-rebuild.cron
> LILYPOND_GIT=/home/graham/lilypond/lilypond-git/
> LILYPOND_WEB_MEDIA_GIT=/home/graham/lilypond/lilypond-extra/

PATH=/home/graham/usr/bin/:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin


> Do we need to do a similar thing for this crontab?

lilypond-patchy-staging reads LILYPOND_GIT from environment only if
git_repository_dir from configuration does not point to a valid Git
repository, so I think a default environment could be used for
lilypond-patchy-staging.

>   Cron has a really annoying
> habit of not loading your default environment.  I can't remember if
Patchy
> relies on those environment vars for anything, but it might be safer
to add a
> warning about this.
> (or dump a @ref{Uploading and security} to see the type of thing I
mean; lines
> 211 to 224 in website-work.itexi )

Oh yeah, I rely on ssh-agent for unlocking the ssh-key used by
lilypond-patchy-staging, and my ~/.bashrc (well, the .bashrc of the
account used exclusively for LilyPond development) loads ssh-agent
information, so I ended up using "/bin/bash -lc" in the crontab, but
what you propose for the website is certainly safer.

Description:
Patchset for fixing 2604 and 2524, also contains another patch for CG

Oops, the two commits have been merged into one, but they were initially
two.

CG: improve Patchy documentation

CG: Add LILYPOND_BUILD_DIR environment variable, fix issues 2604 and
2524.

Please review this at http://codereview.appspot.com/6354044/

Affected files:
  M Documentation/contributor/administration.itexi
  M Documentation/contributor/introduction.itexi
  M Documentation/contributor/release-work.itexi
  M Documentation/contributor/website-work.itexi