[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: formatted GNUmakefile

From: John Mandereau
Subject: Re: formatted GNUmakefile
Date: Mon, 02 Jul 2012 21:21:56 +0200

Il giorno lun, 02/07/2012 alle 05.47 +0200, Werner LEMBERG ha scritto:
> >> SUBDIRS = \
> >>   python scripts \
> > 
> > I'm a big fan of splitting lists into one entry per line; esp. if
> > you break at position 20 rather than 78.
> Yes!  Of course, if you have a lot of small entries like
>   SUBDIRS = \
>     foo bar baz foz fuz buz
> vertical alignment is probably harder to read.
> >> test-clean: test-snippets-clean
> >>    $(MAKE) -C input/regression \
> >>            out=test \
> >>            clean
> > 
> > This would be debatable.  As it is only 50 characters wide, I would
> > probably put in on one line.  Otoh, it helps with the diff rule
> > above.  Mostly a matter of taste.
> Indeed.  If there are a lot of similarly looking statements within a
> single Makefile (as the above), I prefer similar formatting of all
> entries, even if this sometime causes very short lines.

Good points.  To augment the chance of tackling this issue completely,

* could you and Jan decide a formatting convention that we can apply by
hand or with a script?

* do you plan to submit a patch (a git-formatted patch is enough, I'll
take care of creating rietveld and google code issues) any time soon
(say, one week), or are you leaving this up to somebody else?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]