|
From: | graham |
Subject: | Fix Issue 2146 "Illegal entry in bfrange block in ToUnicode CMap" (issue 6399046) |
Date: | Sun, 15 Jul 2012 00:21:16 +0000 |
wow, awesome work! http://codereview.appspot.com/6399046/diff/1/Documentation/common-macros.itexi File Documentation/common-macros.itexi (right): http://codereview.appspot.com/6399046/diff/1/Documentation/common-macros.itexi#newcode16 Documentation/common-macros.itexi:16: % code stolen from Heiko Oberdiek's `ifpdf' package sorry to nitpick, but could you use the word "copied" instead? there's no benefit to waving a red flag to anybody doing casual greps and looking for trouble. http://codereview.appspot.com/6399046/diff/1/configure.in File configure.in (right): http://codereview.appspot.com/6399046/diff/1/configure.in#newcode66 configure.in:66: _NCSB_SOURCE_FILES_="" what's the convention for leading _ in names? I havent' encountered this before. http://codereview.appspot.com/6399046/diff/1/scripts/build/lys-to-tely.py File scripts/build/lys-to-tely.py (right): http://codereview.appspot.com/6399046/diff/1/scripts/build/lys-to-tely.py#newcode69 scripts/build/lys-to-tely.py:69: %%%% code stolen from Heiko Oberdiek's `ifpdf' package ditto http://codereview.appspot.com/6399046/
[Prev in Thread] | Current Thread | [Next in Thread] |