Re: Issue 1320: Scheme bar line interface (issue 6305115)

[Marc Hohl]

Am 23.07.2012 23:45, schrieb address@hidden:
> Looks like LilyPond defines two line-thicknesses,
> one for staff-line thickness in each StaffSymbol,
> and one (confusingly called staffline in C) for bar-line width in
> paper.scm.
Thanks for your explanation! Indeed, staffline is not the
best variable name in this case, I changed it accordingly (see below).
> If the barlines use the layout thickness, as they mostly did in the C
> version, then they line up between staves of different staffline
> thicknesses.
... and the difference in input/regression/staff-tweak.ly is gone!
> http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm
> File scm/bar-line.scm (right):
>
> http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode144 
>
> scm/bar-line.scm:144: (stafflinethick (ly:staff-symbol-line-thickness
> grob))
> this one was not like the others in the C version, but maybe that was a
> bug.
I am not sure either, so I left it unchanged.
> http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode155 
>
> scm/bar-line.scm:155: (line-thickness (ly:staff-symbol-line-thickness
> grob))
> unused ?
Removed.
> http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode207 
>
> scm/bar-line.scm:207: (line-thickness (ly:staff-symbol-line-thickness
> grob))
> From layout, or just the value 'thickness' passed in ?
Done.
> http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode257 
>
> scm/bar-line.scm:257: (let* ((line-thickness
> (ly:staff-symbol-line-thickness grob))
> from layout.
Done.
> http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode339 
>
> scm/bar-line.scm:339: (line-thickness (ly:staff-symbol-line-thickness
> grob)))
> Confirming, yes, from staff-symbol because it refers to staffline
> thickness
I renamed it to staff-line-thickness to emphasize the difference.
> http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode372 
>
> scm/bar-line.scm:372: (let* ((line-thickness
> (ly:staff-symbol-line-thickness grob))
> from layout
Done.
> http://codereview.appspot.com/6305115/diff/46004/scm/bar-line.scm#newcode464 
>
> scm/bar-line.scm:464: (let* ((line-thickness
> (ly:staff-symbol-line-thickness grob))
> the C version used the line-thickness from paper.scm. That is, thickness
> of vertical lines comes from layout, not from staff.
Done.

> http://codereview.appspot.com/6305115/