Re: Allows user to set ChordName text (issue 6496085)

[address@hidden]

On 12 sept. 2012, at 19:16, address@hidden wrote:

> On 2012/09/12 16:11:05, dak wrote:
> 
>> when it should rather have the form
> 
>>   if (rest_event_)
>>     {
>> -       SCM no_chord_markup = get_property ("noChordSymbol");
>> -       if (!Text_interface::is_markup (no_chord_markup))
>> ...
>> +     if (make_markup)
>> +       {
>> +         SCM no_chord_markup = get_property ("noChordSymbol");
>> +         if (!Text_interface::is_markup (no_chord_markup))
>> ...
>> +       }
>>     } else
> 
> Actually, come to think of it you might want to move
> if (make_markup)
> upwards to surround the whole if (rest_event_), and then you will
> arrive at the situation where a markup (and all information required
> for it) is only calculated when it will get used, addressing the next
> point as well.
> 
> That was the intent of the original suggestion.
> 

Excellent - this is the exact type of feedback I needed.  Many thanks.

Cheers,
MS

> 
> http://codereview.appspot.com/6496085/