[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Sets TabVoice Stem height to ##f (issue 6303065)
From: |
Keith OHara |
Subject: |
Re: Sets TabVoice Stem height to ##f (issue 6303065) |
Date: |
Mon, 17 Sep 2012 01:24:29 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
mike <at> apollinemike.com <mike <at> apollinemike.com> writes:
> >> > On 2012/06/12 12:49:45, dak wrote:
> >> > > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc
> >> > > File lily/grob.cc (right):
> >> > >
> >> > >
> > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472
> >> > > lily/grob.cc:472: real_ext[d] += offset;
> >> > > On 2012/06/12 12:32:37, dak wrote:
> >> > > > I don't understand this. The only way to get a nan from adding
> > an offset
> >> to
> >> > > > infinity is by adding another nan or an infinite offset with
> > different
> >> sign.
> >> > > >
> >> > > > What case is this supposed to catch?
The Flags in TabVoice had empty extent, and position at the end of their
Stems, which also had empty extents. So we had (inf . -inf) being offset
by -inf.
The skyline code is not robust to NaNs, so with skylines being made
for all objects, NaNs in extents become more of a problem.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Sets TabVoice Stem height to ##f (issue 6303065),
Keith OHara <=