Re: Various clean-ups in stems and beams. (issue 6584045)

[aleksandr . andreev]

On 2012/10/02 14:56:28, mike7 wrote:
> On 2 oct. 2012, at 16:42, mailto:address@hidden wrote:

> > What I mean is that if something like
> >
> > {
> > \override NoteHead #'style = #'kievan
> > c'8
> > }
> >
> > produces a quarter note in the output, the user is likely to be
> > thoroughly confused.

> Is this because of the duration-log override?

Yes.

> NoteHead #'duration-log for
> Kievan notation should be a separate function that is not based on
style (this
> is what I propose in my patch).


Then it has to be set with an override whenever the style is set to
kievan.


> Why can't we have commands \startKievan and \stopKievan that do all
the
> overrides simultaneously?

I think that would work.

> For example, the command \hideNotes groups together several overrides.
 I think
> it would be a mistake to make \override NoteHead #'transparent also
control Dots
> and Stems by default.

Sure. The trouble is that Stems don't make much sense when NoteHead
style is set to kievan and warnings are produced with beams. Of course,
we could rewrite the way that is handled in stem::is_normal_stem, but
that would take some thought.

>   It's better to have a global command that groups together
> all these overrides.


Definitely.

> I think it's important to keep properties as separate as possible.
For example,
> take the command arpeggioParenthesisDashed.  In theory, we could make
it such
> that arpeggio has a style property that'd set all these things, but
it's better
> to keep them as separate overrides to various parameters.  Same for
easyHeadsOn,
> improvisationOn, and tabFullNotation.  A command like \startKievan or
\kievanOn
> or whatever should work like this.

I agree, but see the above comment about Stems not being normal.

http://codereview.appspot.com/6584045/