Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

[janek . lilypond]

I found some ambiguities in descriptions.

Janek


http://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly
File input/regression/measure-counter-broken.ly (right):

http://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly#newcode6
input/regression/measure-counter-broken.ly:6: enclosed in parentheses."
Do you mean that the number before the break is not parenthesized, and
the number of the part after the break is parenthesized?
It may be worth rewording this sentence.

http://codereview.appspot.com/6730044/diff/10001/scm/define-event-classes.scm
File scm/define-event-classes.scm (right):

http://codereview.appspot.com/6730044/diff/10001/scm/define-event-classes.scm#newcode49
scm/define-event-classes.scm:49: tremolo-span-event tuplet-span-event))
i think there's something wrong with the indentation here, but
considering how nitpicking about indentation didn't do us any good in
the past i'm leaning towards not caring about it.

http://codereview.appspot.com/6730044/diff/10001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/6730044/diff/10001/scm/define-grob-properties.scm#newcode204
scm/define-grob-properties.scm:204: (count-from ,integer? "The number
beginning a measure count.")
I suppose you mean "In a measure count, don't print numbers lower than
this one"?
I mean, count-from could work either like this
{
  \override MeasureCount count-from = 3
  \startMeasureCount
  a1 % no number
  b1 % no number
  a1 % 3
  b1 % 4
}
or like this
{
  \override MeasureCount count-from = 3
  \startMeasureCount
  a1 % 3
  b1 % 4
  a1 % 5
  b1 % 6
}
It's important to make it clear in which way count-from works.

http://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):

http://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm#newcode27
scm/scheme-engravers.scm:27: spanners.  Each spanner is bounded by the
first command column of successive
what is a command column?

http://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm#newcode61
scm/scheme-engravers.scm:61: ; if this is not done, _all_ command
columns will be numbered
so, sometimes all command columns will be nubmered?

or do you mean that the code needs to make sure that we're in a new bar
because if it didn't, all command columns would be numbered and that's
something we don't want?

In other words, maybe "_all_ command columns would be numbered" would be
a better wording?

http://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm#newcode67
scm/scheme-engravers.scm:67: ; first column of measure, even if grace
notes appear?
umm, i don't understand.  Is it a question about what this code actually
does?  Or some kind of rhethoric-question-comment? ;)

http://codereview.appspot.com/6730044/