[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Allow music of nominally zero duration to be typeset. (issue 6810087
From: |
benko . pal |
Subject: |
Re: Allow music of nominally zero duration to be typeset. (issue 6810087) |
Date: |
Sat, 17 Nov 2012 11:05:12 +0000 |
On 2012/11/16 22:57:29, dak wrote:
On 2012/11/16 22:13:59, benko.pal wrote:
> LGTM in the sense that it won't make things worse; I've tried to
understand
> the code but failed, see below.
I have not actually tried to understand the code. I just added checks
for
existing array elements before access until I could no longer make
LilyPond
segfault or produce programming errors.
So this is, indeed, strictly a patch on the "won't make things worse"
basis,
except for the one, initial removal of a zero-duration check,
necessary for sane
behavior in things like incipits without notes.
yes, the commit message made me guess so; I hoped someone (Joe?) would
chime in.
L still GTM
http://codereview.appspot.com/6810087/