lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES (issue 7


From: lilyfan
Subject: PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES (issue 7029043)
Date: Sat, 29 Dec 2012 18:53:02 +0000

Reviewers: dak, phileholmes_googlemail.com, Graham Percival,

Message:
Please review

Description:
PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES

Introduced with version 1.0.1 :
  in stepmake/stepmake/C.make
    ALL_C_SOURCES = h, c, y and l files
  in stepmake/stepmake/Targets.make
    ALL_PO_SOURCES = $(ALL_C_SOURCES) $(wildcard $(outdir)/*.hh)
$(wildcard $(outdir)/*.cc)

hh and cc files having since then been registered through
ALL_CC_SOURCES,
there is no need to double their entry,
Even worse, an "out of tree build" results in a doubled location of
parser.yy and lexer.ll (one with a full path).

Please review this at https://codereview.appspot.com/7029043/

Affected files:
  M stepmake/stepmake/po-targets.make


Index: stepmake/stepmake/po-targets.make
diff --git a/stepmake/stepmake/po-targets.make b/stepmake/stepmake/po-targets.make index c971e513c034b8dcc6e45ef4ae05db00ea33370c..8919dab8239e69f0378a0d6071fc1d249f8bbff0 100644
--- a/stepmake/stepmake/po-targets.make
+++ b/stepmake/stepmake/po-targets.make
@@ -29,7 +29,7 @@ local-po:
 else
 po: local-po
        $(LOOP)
-ALL_PO_SOURCES = $(ALL_C_SOURCES) $(ALL_CC_SOURCES) $(PYTHON_SCRIPTS_IN) $(PY_MODULES_IN) $(SCM_FILES) $(wildcard $(outdir)/*.hh) $(wildcard $(outdir)/*.cc) +ALL_PO_SOURCES = $(ALL_C_SOURCES) $(ALL_CC_SOURCES) $(PYTHON_SCRIPTS_IN) $(PY_MODULES_IN) $(SCM_FILES)
 local-po:
 ifneq ($(strip $(ALL_PO_SOURCES)),)
        @echo $(ALL_PO_SOURCES)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]