Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

[ianhulin44]

I don't think \tuplet needs the tupletSpannerDuration property. Do it
all in-line using the optional @var{duration} parameter.  (Maybe call
this spanner-duration). See comments below.

Cheers,

Ian


https://codereview.appspot.com/7058068/diff/4/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/7058068/diff/4/ly/music-functions-init.ly#newcode1344
ly/music-functions-init.ly:1344: being played in place of two.  If the
optional @var{duration} is
If the optional @var{duration} parameter is specified, this is used to
have the tuplet use spanner brackets differing from the total length of
the music in the tuplet. Typically this could be used to specify a group
of subdivisions within the tuplet.
For example,

https://codereview.appspot.com/7058068/diff/4/ly/music-functions-init.ly#newcode1351
ly/music-functions-init.ly:1351: quarter note.  The value of
@code{tupletSpannerDuration} is retained
Cut out these sentences
"The value of @code{tupletSpannerDuration} is retained as default if it
is set in this manner. Clearing it can be achieved by specifying
@samp{1*0} as @var{duration}"

https://codereview.appspot.com/7058068/diff/4/ly/music-functions-init.ly#newcode1372
ly/music-functions-init.ly:1372:
Get rid of code doing things to tupletSpannerDuration.  I think this
property was a kludge they put in because you couldn't code an optional
parameter when the old \times commands was written.
Look at the NR example for tupletSpannerDuration:

{
  \set tupletSpannerDuration = #(ly:make-moment 1 4)
  \times 2/3 { c8 c c c c c }
}

WDYT?

Cheers,

Ian

https://codereview.appspot.com/7058068/