[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Creates Skyline_forest smob (issue 7098069)
From: |
dak |
Subject: |
Re: Creates Skyline_forest smob (issue 7098069) |
Date: |
Sat, 26 Jan 2013 12:51:02 +0000 |
https://codereview.appspot.com/7098069/diff/4001/lily/skyline-forest.cc
File lily/skyline-forest.cc (right):
https://codereview.appspot.com/7098069/diff/4001/lily/skyline-forest.cc#newcode28
lily/skyline-forest.cc:28: A skyline forest is, conceptually, a skyline
pair that can have
"forest" is a strange choice of word here. In computer science, a
"forest" is a collection of trees without common root, but we don't have
trees in here. So it is more like an object composition or a skyline
pair compound or whatever.
https://codereview.appspot.com/7098069/diff/4001/lily/skyline-forest.cc#newcode68
lily/skyline-forest.cc:68: other skylines in a forest.
That does not make sense. If you are talking about "other skylines in a
forest", presumably the skyline pair under consideration is considered
to be part of the forest. Why would it need to move to avoid "other
skylines" then? Are skylines in a forest supposed to intersect? That's
not what (physical) trees do. And what is "minimum distance"?
According to which metric? And why "distance_to_avoid"? Sounds rather
like the distance to move rather than to avoid. How is a "forest"
created? It sounds like you try to make it consist of non-overlapping
objects?
What is the purpose of a forest? Is the focus on arranging a set of
skyline pairs non-overlappingly, or is the focus on being able to move
it as a whole?
https://codereview.appspot.com/7098069/