Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

[David Kastrup]

"address@hidden" <address@hidden> writes:

> On 24 févr. 2013, at 16:37, address@hidden wrote:
>
>> On 2013/02/24 13:27:39, mike7 wrote:
>>> On 24 févr. 2013, at 12:40, mailto:address@hidden wrote:
>> 
>>> > Stupid question: could you not just check whether
>>> > outside-staff-priority has been set, and if it has, pass the buck
>>> > to the right kind of callback automatically?  That way, the user
>>> > does not need to meddle with callbacks himself.
>>> >
>>> > https://codereview.appspot.com/7185044/
>> 
>>> Yup, but it'd require creating an Outside_staff_callback engraver
>>> with a call to acknowledge_grob.  Calls to acknowledge_grob are
>>> expensive and should be used only if there's no other viable
>>> solution.
>> 
>> Why can't the current Y-offset callback check outside-staff-priority
>> on the grob?  Why would there be a need for an acknowledger?
>> 
>
> That's exactly how the new Y-offset callbacks are implemented in this
> patch set.  The problem is that not all grobs have a Y-offset
> callback.

Well, something heeded outside-staff-priority previously, apparently
calculating an offset based on it.  What happened to it?

-- 
David Kastrup