Re: Alternative pixel-based regtest checker

[Phil Holmes]

----- Original Message ----- 
From: "Julien Rioux" <address@hidden>
To: "LilyPond Devel" <address@hidden>
Sent: Sunday, March 10, 2013 12:50 AM
Subject: Re: Alternative pixel-based regtest checker


> On 01/03/2013 2:15 PM, Phil Holmes wrote:
> > 4 files attached.  To try this out: create a new directory and place
> > NoTagline.ly in it.  Create a subdirectory called input and put some
> > regtest files in there.  Run MakeOldPix.sh.  Make a change to lilypond.
> > Run MakeNewPix.sh.  Run ComparePix.sh.  Om my tests there were some
> > false alarms, but it seems a fairly simple way to make an alternative
> > regtest checker.
> >
> > There's lots of improvements that could be made: parallelism, using
> > something other than diff, but it basically works.
> >
> > Thoughts?
> >
> > --
> > Phil Holmes
> >
> >
> >
> > _______________________________________________
> > lilypond-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/lilypond-devel
>
> I haven't tested your code, I am sure it is useful, I just have one thing 
> to note: Are you aware of the --threshold command-line switch for 
> script/build/output-distance.py? I wonder if setting it to a lower default 
> value would not reveal the "missing" regtest changes that you are 
> presumably looking for.
>
> --
> Julien


I haven't tried, but would be surprised if it makes any difference.  The 
missing span bars slap you in the face when viewed optically - they're huge 
changes.  So either output-distance would have spotted them, or it doesn't 
check for them.  I think it's highly likely it's the latter, since it's 
based on signature files, not the actual output.

--
Phil Holmes